adding FromField and ToField instances for UTCTime #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ocramz the logs for this PR moved to https://travis-ci.org/haskell-hvr/cassava/builds/264861856 However, I'm not convinced this PR to be non-controversial enough at this point. At the very least I'd expect a canonical ISO8601 based serialisation (including a timezone designation, like a trailing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I appreciate your cassava repo.
Including these FromField and ToField instances for time's UTCTime would be useful to me.
Please feel free to let me know if I can be of help in getting this feature included.
Thank you!
Matthew